Skip to content

Refactor FancyHeader to Use CSS Grid for Dynamic Height#214

Open
betsyecastro wants to merge 2 commits into
developfrom
fix-fancy-header-layout
Open

Refactor FancyHeader to Use CSS Grid for Dynamic Height#214
betsyecastro wants to merge 2 commits into
developfrom
fix-fancy-header-layout

Conversation

@betsyecastro
Copy link
Copy Markdown
Contributor

Replaces the fixed-height background-image approach with an <img> tag and CSS Grid. This allows the header height to adjust dynamically based on either the image or the content, whichever is taller.
Changes

  • Replaced inline background-image style with <img class="banner-img"> element
  • Used CSS Grid to layer the image and content on top of each other in the same cell
  • Removed fixed height: 85vh in favor of dynamic sizing
  • Added object-fit: cover and object-position: center for consistent image scaling
  • Removed max-height and overflow-y: auto from .contact_info to let content flow naturally
  • Overrode .profile-header padding and background on .fancy_header to prevent style conflicts

@betsyecastro betsyecastro self-assigned this Apr 21, 2026
@betsyecastro betsyecastro added 🐛 bug Something isn't working 💄 design Related to visual look / appearance labels Apr 21, 2026
@betsyecastro
Copy link
Copy Markdown
Contributor Author

The last commit hides the banner image on screens below lg breakpoint (992px).

@betsyecastro betsyecastro marked this pull request as ready for review April 23, 2026 19:31
@shukla-m shukla-m self-requested a review April 23, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working 💄 design Related to visual look / appearance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant