added default keyword parameters to ICollector to help write correct and safe scope and stack pushes and pops. shorthands for manual enter/leave, push/pop pairs#27
Open
jurgenvinju wants to merge 2 commits intomainfrom
Conversation
…and safe scope and stack pushes and pops. shorthands for manual enter/leave, push/pop pairs
…atted a switch and changed list to tuple syntax for better efficiency
d95f86d to
cb99eee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a priority. Added some enhancements to
ICollectorbe able to write:instead of:
The
scopeshorthand (and its siblingslubScope,compositeScope,compositeLubScope, ...) also wraps a try-finally block around the block, such that in the presence of unexpected exceptions the scope stacks are properly unwound automatically.The changes are located purely in the abstract definition of
ICollectoras a list of keyword parameters that call the other function fields. So thescopekeyword parameter calls theenterScopeandleaveScopepositional field, etc. There is no impact on other code in typepal.