Added missing "aempty" in various places - #2864
Open
PaulKlint wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2864 +/- ##
=======================================
- Coverage 46% 46% -1%
- Complexity 6767 6769 +2
=======================================
Files 844 844
Lines 67096 67096
Branches 10021 10021
=======================================
- Hits 30881 30880 -1
Misses 33838 33838
- Partials 2377 2378 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| when r is \achar-class || r is aempty || r is seq || r is opt || r is alt || r is iter || r is \iter-star || r is \iter-seps || r is \iter-star-seps; | ||
| AType alub(AType l, r:aadt("Tree", _, _)) = r | ||
| when l is \achar-class || l is seq || l is opt || l is alt || l is iter || l is \iter-star || l is \iter-seps || l is \iter-star-seps; | ||
| when l is \achar-class || r is aempty || l is seq || l is opt || l is alt || l is iter || l is \iter-star || l is \iter-seps || l is \iter-star-seps; |
Member
There was a problem hiding this comment.
I think this should be l is aempty (instead of r). Perhaps this whole disjunction could be a predicate?
Member
Author
There was a problem hiding this comment.
Very sharp! And you are right a predicate is better. Thanks.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.