Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2659 +/- ##
=======================================
Coverage 46% 46%
+ Complexity 6677 6668 -9
=======================================
Files 795 795
Lines 65899 65945 +46
Branches 9878 9895 +17
=======================================
+ Hits 30709 30733 +24
- Misses 32806 32825 +19
- Partials 2384 2387 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Member
I think there's some uncommitted file? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes unicode offsets for the JSON parser/validator:
srckeyword fieldslocsemantics of vallang and Rascal (offset, length, line, column)This makes JSON parsers ready for use in an editor/UI context. From that perspective, this was a bug. From the "we had a reasonable JSON parser" perspective, this was an enhancement.
Instruments the OriginTrackingReader embedded in JSONValueReader to accurately deal with the presence of unicode surrogate pairs in the char buffer of the reader.
Note that unicode characters in comments are equally responsible for shifts in the offsets as unicode characters in string constants and field names.
posindex into buffer compensated for surrogate pairsThe current solution still streams quickly and scales freely to very long JSON content, very long lines in JSON content, and very long comments or strings in JSON content.