Skip to content

Conversation

@prashantpandeygit
Copy link

Fixes #283

Enabled branch specific container image tags for urunc-deploy, removed the hardcoded latest tag, with this it is easy to deploy and test with versions.

Changes

added images field so that override can be done on the tag,
script to get tag from the git state. (also, the tag remains :latest as default, making backward compatible)

Tests

getting the tag:

image

kustomize build on urunc-deploy (same for cleanup):

image

set the tag:

image

verifying through build:
image

@netlify
Copy link

netlify bot commented Jan 22, 2026

Deploy Preview for urunc ready!

Name Link
🔨 Latest commit 06467ae
🔍 Latest deploy log https://app.netlify.com/projects/urunc/deploys/6972aacd588cb100086a2874
😎 Deploy Preview https://deploy-preview-386--urunc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@prashantpandeygit
Copy link
Author

@ananos @cmainas have a look please when you get a moment. thanks!

Copy link
Contributor

@cmainas cmainas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @prashantpandeygit ,

thank you for this PR. Unfortunately, these changes do not resolve correctly the referenced issue:

  • There is no reason for a script to obtain the current tag/hash.
  • We should also update the respective documentation to also include the necessary steps to specify the version of urunc-deploy to use.
  • The changes do not resolve the first point of the issue
When we push a new commit to main, we should be able to calculate the commit hash of the current tip of main, and use this as the tag to the container image built and pushed using the automated action.

@prashantpandeygit
Copy link
Author

thanks for the review @cmainas , my bad i interpreted the issue that the tag should be overridden by using script as it was mentioned.

so we need to make changes to the CI so that the tag gets automatically updated when a new image is built? is there something more that would help making these changes? thanks!

Signed-off-by: prashantpandeygit <prashantpandeyiuet@gmail.com>
@prashantpandeygit
Copy link
Author

prashantpandeygit commented Jan 22, 2026

I tried to work around and i guess this must work, i could only test the tag changing locally.

also used sed to change string, that must not create issue as we are on ubuntu 22.04

and took the identity from pr-takeover.yml, hope that is correct

will add docs if this approach is fine

@prashantpandeygit prashantpandeygit marked this pull request as ready for review January 22, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

urunc-deploy: Use a specific tag for urunc-deploy container image

2 participants