-
Notifications
You must be signed in to change notification settings - Fork 36
specific tag for deploy container image as per branch #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ca3d3e8 to
9c484dc
Compare
cmainas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @prashantpandeygit ,
thank you for this PR. Unfortunately, these changes do not resolve correctly the referenced issue:
- There is no reason for a script to obtain the current tag/hash.
- We should also update the respective documentation to also include the necessary steps to specify the version of
urunc-deployto use. - The changes do not resolve the first point of the issue
When we push a new commit to main, we should be able to calculate the commit hash of the current tip of main, and use this as the tag to the container image built and pushed using the automated action.
|
thanks for the review @cmainas , my bad i interpreted the issue that the tag should be overridden by using script as it was mentioned. so we need to make changes to the CI so that the tag gets automatically updated when a new image is built? is there something more that would help making these changes? thanks! |
593971b to
b7f8c89
Compare
Signed-off-by: prashantpandeygit <prashantpandeyiuet@gmail.com>
b7f8c89 to
06467ae
Compare
|
I tried to work around and i guess this must work, i could only test the tag changing locally. also used sed to change string, that must not create issue as we are on ubuntu 22.04 and took the identity from will add docs if this approach is fine |
Fixes #283
Enabled branch specific container image tags for
urunc-deploy, removed the hardcoded latest tag, with this it is easy to deploy and test with versions.Changes
added
imagesfield so that override can be done on the tag,script to get tag from the git state. (also, the tag remains
:latestas default, making backward compatible)Tests
getting the tag:
kustomize build on
urunc-deploy(same for cleanup):set the tag:
verifying through build:
