NP-01 chore: add type hints and enable strict mypy #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uptickmetachu
commented
Jan 21, 2026
| app = FastAPI() | ||
|
|
||
| @asynccontextmanager | ||
| async def lifespan(app: FastAPI) -> AsyncIterator[None]: |
Collaborator
Author
There was a problem hiding this comment.
Wait a second this is... a feature hange claude.
Pwnion
previously approved these changes
Jan 22, 2026
Pwnion
left a comment
Pwnion
left a comment
There was a problem hiding this comment.
Ran through the test plan, all looks good. Just some nitpicks.
| app = FastAPI() | ||
|
|
||
| @asynccontextmanager | ||
| async def lifespan(app: FastAPI) -> AsyncIterator[None]: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve code quality and developer experience by adding comprehensive type hints throughout the codebase and enabling strict mypy type checking. This helps catch type-related bugs at development time and makes the code more self-documenting.
Changes
gitops/andgitops_server/modulestypes-invokepackage for invoke library type stubsFiles changed: 26 files across CLI and server components
Test Plan
uv run mypy gitops/ gitops_server/and verify no errorsuv run pytestto ensure all tests still passuv run ruff check .to verify no linting issuesgitops summary)