Validate log --service, --app and --worker names against the deployment

[upsun-dispatch]

With the auto log protocol, log now checks --service, --app and --worker against the environment's current deployment. An unknown name prints a warning listing the valid names, and is still queried, as logs of removed or renamed services are retained. If the name is a log type (e.g. --service access), the warning suggests passing it as an argument instead.

--worker no longer forces SSH: it filters the logs API by the worker's qualified <app>--<worker> name. A bare short name is resolved against the deployment with the same rules as ssh --worker (now in Selector::selectWorkerName()), so an ambiguous or missing short name is an error. A qualified name, or a short name with --app, is passed through (Selector::qualifyWorkerName()).

The deployment is only fetched when a service, app or worker filter is set. If there is no current deployment, names are not validated, and a short --worker name without an app is an error.

Not checked: that the logs API names worker logs <app>--<worker> (as the metrics commands do), and that router is a valid logs service name. Before merging, run log --format json on an environment with a worker and check the service field.

Changes:

• legacy/src/Selector/Selector.php: the --worker branch of selectRemoteContainer() is split into qualifyWorkerName() and selectWorkerName(), with the same messages and prompt.
• legacy/src/Command/Environment/EnvironmentLogCommand.php: new resolveServices(); --worker no longer triggers SSH (the help text is updated).
• integration-tests/environment_log_test.go: adds a deployment to TestEnvironmentLogAPI, and covers worker selection, warnings for unknown names (with and without the log type hint), and short worker name errors.

---

Created by Upsun Dispatch™, review comments addressed by Claude Code.

🤖 Generated with Claude Code

[upsun-dispatch]

Warning

Changes suggested — 🟡 1 warning · 🔵 1 minor point

🔍 Full review · 3 files reviewed

Verification

• buildFilters() is called only once, from readFromApi() before the time window is parsed, so the worker prompt and the verbose Selected worker line come once per command, not once per page or per tail poll.
• selectWorkerName() keeps the old worker branch unchanged: the case-insensitive conflict check, direct lookup, suffix match, the non-interactive ambiguity error and the prompt. selectRemoteContainer() still wraps the result with getWorker().
• Selection::getAppName() already merges the --app option, the app ID from the project URL and <PREFIX>APPLICATION_NAME, so resolveServices() validates the app from all three sources.
• Api::getCurrentDeployment throws EnvironmentStateException for inactive environments, so log on an inactive environment falls back to the no-validation path and does not fail.

TestEnvironmentLogAPI in integration-tests/environment_log_test.go adds a deployment fixture and covers worker resolution, invalid service/app/worker errors and that no query is sent after an error. Nothing tests the path where there is no current deployment. The refactored SSH worker path is covered by the existing TestSSHAppSelection cases, which the author could not run locally.

Review details

• Commit: 902c4e8
• Model: claude-opus-5-5

---

Review 1 of 10 for this pull request · View the full run

[upsun-dispatch]

📋 PR Summary

With the auto log protocol, log now checks the --service, --app and --worker names against the environment's current deployment. An unknown name prints a warning that lists the valid names, plus a hint when the name is a log type, and the name is still queried. --worker now filters the logs API by the qualified <app>--<worker> name and no longer forces SSH. Short worker names are resolved with the same shared Selector logic that ssh --worker uses. The latest push only re-wraps a long assertion line in the integration test.

Changes

Layer / File(s)	Summary
Worker selection
legacy/src/Selector/Selector.php	The --worker handling in selectRemoteContainer() is split out into qualifyWorkerName() and selectWorkerName(), with the same messages and prompt as before.
Log command
legacy/src/Command/Environment/EnvironmentLogCommand.php	Adds resolveServices(), which checks service, app and worker names against the deployment and warns about unknown ones. --worker no longer triggers SSH, and the help text is updated.
Tests
integration-tests/environment_log_test.go	Adds a deployment to TestEnvironmentLogAPI and covers worker selection, warnings for unknown names (with and without the log type hint), and errors for short worker names. The latest push only re-wraps one assertion line.