Skip to content

move 'react-syntax-highlighter' to devDependencies#36

Open
mikaello wants to merge 1 commit into
upmostly:masterfrom
mikaello:remove-react-syntax-highlighter-to-dev-dependencies
Open

move 'react-syntax-highlighter' to devDependencies#36
mikaello wants to merge 1 commit into
upmostly:masterfrom
mikaello:remove-react-syntax-highlighter-to-dev-dependencies

Conversation

@mikaello

@mikaello mikaello commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

Using command: npm install react-syntax-highlighter@10.2.1 --save-dev

Sorry for the mess in #33, I'll keep this branch clean :-)

(and if you're interested in any of the features I have implemented in my own fork (http://github.com/mikaello/modali), I'll be more than happy to prepare PR-s for those of interest).

Resolving issue #28

Using command: npm install react-syntax-highlighter@10.2.1 --save-dev
@jcrowson

jcrowson commented Nov 7, 2019

Copy link
Copy Markdown
Contributor

Fantastic, @mikaello ! I'll merge this in now.

@dinoshauer

Copy link
Copy Markdown

@jcrowson gentle bump :) I guess this would fix the security warning for highlight.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants