Repository navigation
Fix IBL creation failure fallback and spurious bake attempts - #1382
Merged
Merged
Conversation
Zero-fill IBL textures when generateHDR fails, instead of leaving uninitialized/garbage data bound to the render pass, so a failed bake is ignored rather than turning models black. Also skip the bake attempt entirely when hdrURL is empty (no environment configured), which stops the spurious iBLCreationFailed error previously logged on unrelated viewport resizes after loading an HDR-less scene. Fixes #1380
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateHDRfails, instead of leaving whatever uninitialized/garbage data Metal allocated bound to the render pass — a failed bake is now ignored (no ambient contribution) instead of turning models black.hdrURLis empty (no environment configured for the scene), which stops the spuriousiBLCreationFailed(error 1018) previously logged on unrelated viewport resizes/inits after loading an HDR-less scene.generateHDR's earlier GPU-resource-creation guards now also setiblSuccessful = false, consistent with the catch block.Fixes #1380
Test plan
swift buildswift test --filter "EnvironmentAssetRebakeTests|RuntimeEnvironmentLightingTests|EnvironmentReflectionShadingTests"— all passswift test --filter "RendererTest"— all pass, no more spuriousError: 1018in logs