Skip to content

[Bugfix] Don't require lightTile pipeline success on devices without tile shading #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
untoldengine merged 1 commit into from
Oct 23, 2026
Merged

[Bugfix] Don't require lightTile pipeline success on devices without tile shading #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Tests/UntoldEditorTests/EditorRenderPipeLinesTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,14 +471,23 @@ final class EditorRenderPipeLinesTests: XCTestCase {
}

func test_EditorDefaultPipeLines_canInitializeAllPipelines() {
// This test verifies that all pipelines in EditorDefaultPipeLines can be initialized
// This test verifies that all pipelines in EditorDefaultPipeLines can be initialized.
// .lightTile is nil on devices without tile-shading support (the simulator, GPUs
// before Apple family 4, or CI's paravirtualized GPU) — that's expected engine
// behavior, not a failure, so it's excluded the same way UntoldEngine's own
// TileLightStageTests skip via `tileShadingAvailable`.
let tileShadingAvailable = renderInfo.device?.supportsFamily(.apple4) == true
&& renderInfo.device?.name.localizedCaseInsensitiveContains("paravirtual") == false

// Act
let pipelines = EditorDefaultPipeLines()
var allSuccessful = true
var failedPipelines: [String] = []

for (type, initBlock) in pipelines {
if type == .lightTile, !tileShadingAvailable {
continue
}
if let pipeline = initBlock() {
if !pipeline.success {
allSuccessful = false
Expand Down
Loading