Skip to content

New Crowdin updates#1996

Open
elibosley wants to merge 3 commits intomainfrom
l10n_main
Open

New Crowdin updates#1996
elibosley wants to merge 3 commits intomainfrom
l10n_main

Conversation

@elibosley
Copy link
Copy Markdown
Member

@elibosley elibosley commented Apr 24, 2026

Summary by CodeRabbit

  • Localization
    • Updated Hungarian UI copy for notification tooltips, trial-license messaging, uptime labels, and WAN IP check/network-access texts. Standardized terminology and punctuation (e.g., “módosítása”, “Próbalicenc”, “Próbalicenc-kulcs”, “Lejárt: {0}”, “Üzemidő: {0}”), clarified phrasing around VPN/DNS scenarios, and unified remark prefix to “Megj.:” for consistency.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 47cd7a48-b522-462e-93fa-e6a70d5419e0

📥 Commits

Reviewing files that changed from the base of the PR and between 7adb62d and da86dfc.

📒 Files selected for processing (1)
  • web/src/locales/hu.json
✅ Files skipped from review due to trivial changes (1)
  • web/src/locales/hu.json

Walkthrough

Updated Hungarian locale strings in web/src/locales/hu.json: adjusted notification tooltip wording, trial/license phrasing, uptime/expiration labels, WAN IP check messages (DNS/VPN wording), and standardized the remark prefix. All edits are JSON string changes; no behavioral code changes.

Changes

Cohort / File(s) Summary
Hungarian Locale Translations
web/src/locales/hu.json
Text-only revisions: changed notification tooltip from “szerkesztése” to “módosítása”; replaced “próba kulcs” variants with “próbalicenc” / “Próbalicenc-kulcs”; standardized uptime/expiration labels (Lejárt: {0}, Üzemidő: {0}); updated WAN IP check wording (WAN-oldali IP-címek, DNS-hiba), changed VPN phrasing to “VPN-en keresztül”, unified remark prefix to “Megj.:”, and adjusted related message punctuation/structure.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 I hop through strings with a careful twitch,

próbalicenc tucked neat without a glitch,
Lejárt: and Üzemidő set in line,
WAN and DNS now say their line,
Megj.: I hum — translations hop and stitch.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'New Crowdin updates' is vague and generic, using a non-descriptive term that doesn't convey what specific locale or content was updated. Consider a more specific title like 'Update Hungarian locale translations for notifications and uptime messages' to clarify which language and feature areas were modified.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch l10n_main

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@web/src/locales/hu.json`:
- Line 970: The translation string for key
"userProfile.trial.pleaseWaitWhileThePageReloads" contains a typo "próbalicence"
that should match the established term "próbalicenc"; update the value to
replace "próbalicence" with "próbalicenc" so the terminology is consistent with
surrounding strings.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5863ac98-320a-4423-bbb0-b7300000116d

📥 Commits

Reviewing files that changed from the base of the PR and between 865d9cc and 30d122c.

📒 Files selected for processing (1)
  • web/src/locales/hu.json

Comment thread web/src/locales/hu.json
"userProfile.trial.trialKeyCreated": "Próba kulcs létrehozva",
"userProfile.trial.trialKeyCreationFailed": "Próba kulcs létrehozása sikertelen.",
"userProfile.uptimeExpire.expired": "Lejárt {0}",
"userProfile.trial.pleaseWaitWhileThePageReloads": "Kérjük, várjon amíg az oldal újratöltődik a próbalicence kulcsának telepítéséhez.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix trial-license terminology typo in reload message.

Line 970 uses próbalicence, while surrounding strings use próbalicenc. This creates visible terminology inconsistency in the same flow.

💡 Proposed text fix
-  "userProfile.trial.pleaseWaitWhileThePageReloads": "Kérjük, várjon amíg az oldal újratöltődik a próbalicence kulcsának telepítéséhez.",
+  "userProfile.trial.pleaseWaitWhileThePageReloads": "Kérjük, várjon, amíg az oldal újratöltődik a próbalicenc kulcsának telepítéséhez.",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"userProfile.trial.pleaseWaitWhileThePageReloads": "Kérjük, várjon amíg az oldal újratöltődik a próbalicence kulcsának telepítéséhez.",
"userProfile.trial.pleaseWaitWhileThePageReloads": "Kérjük, várjon, amíg az oldal újratöltődik a próbalicenc kulcsának telepítéséhez.",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@web/src/locales/hu.json` at line 970, The translation string for key
"userProfile.trial.pleaseWaitWhileThePageReloads" contains a typo "próbalicence"
that should match the established term "próbalicenc"; update the value to
replace "próbalicence" with "próbalicenc" so the terminology is consistent with
surrounding strings.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.55%. Comparing base (865d9cc) to head (da86dfc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1996      +/-   ##
==========================================
- Coverage   52.56%   52.55%   -0.01%     
==========================================
  Files        1033     1033              
  Lines       71649    71649              
  Branches     8173     8169       -4     
==========================================
- Hits        37659    37655       -4     
- Misses      33865    33869       +4     
  Partials      125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1996/dynamix.unraid.net.plg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant