-
Notifications
You must be signed in to change notification settings - Fork 48
core: a protocol can be registered per client, and a client owns what it creates #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fdce267
core: a protocol can be registered per client, and a client owns what…
h3xxit 40572d8
mcp: register as a factory, so every client owns its own sessions
h3xxit cc76d20
core: a batch registration settles every sibling before raising; a la…
h3xxit f4e87bd
websocket: register as a factory; state the factory criterion precisely
h3xxit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,9 @@ | ||
| from utcp.exceptions.utcp_variable_not_found_exception import UtcpVariableNotFound | ||
| from utcp.exceptions.utcp_serializer_validation_error import UtcpSerializerValidationError | ||
| from utcp.exceptions.utcp_protocol_close_error import UtcpProtocolCloseError | ||
|
|
||
| __all__ = [ | ||
| "UtcpVariableNotFound", | ||
| "UtcpSerializerValidationError" | ||
| "UtcpSerializerValidationError", | ||
| "UtcpProtocolCloseError", | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| from typing import List | ||
|
|
||
|
|
||
| class UtcpProtocolCloseError(Exception): | ||
| """REQUIRED | ||
| Raised when one or more of a client's own protocol instances failed to close. | ||
|
|
||
| Every instance is still asked to close before this is raised, so nothing is | ||
| left half-torn-down behind it; `failures` carries what each failing close raised. | ||
| """ | ||
|
|
||
| def __init__(self, failures: List[BaseException], total: int): | ||
| self.failures = failures | ||
| self.total = total | ||
| super().__init__(f"{len(failures)} of {total} owned communication protocol(s) failed to close: " | ||
| + "; ".join(f"{type(f).__name__}: {f}" for f in failures)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.