Repository navigation
Conversation
Tighten full-dimensional exact-cell containment so neighbouring-cell hints cannot shift continuous-field probes through reference-coordinate clamping. Keep approximate warped-face and embedded-manifold tolerances unchanged. Validation: Gadi int32 installation at feature ef62a45, 22 native regressions in serial and on each of 16 ranks, 272 annulus components, and exact submesh-transfer gates passed. Prior-runtime serial/MPI reproducer has 5.806e-6 error; tight tolerance reduces it below 8e-17. Four matched annulus workflows are being independently audited.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queries close to an exact-cell face can be evaluated at the wrong physical position. The loose cell-wall tolerance admits a neighbouring cell, then PETSc reference-coordinate clamping moves the query onto that face. An exactly representable continuous P1/P2 field with an interface-aligned gradient jump consequently shows a maximum error of 5.806e-6 in both serial and MPI16; tightening containment reduces it below 8e-17.
Use roundoff-scale containment for full-dimensional, geometrically exact cells. Preserve the previous tolerance for approximate warped faces and embedded manifolds. Add P1/P2 kink and global-polynomial regressions, including queries exactly on and on both sides of a shared face. This changes the existing locator's tolerance, without extending its geometric authority.
Validation on Gadi with PETSc int32: 22 UW3 tests pass in serial and on each of 16 MPI ranks; 272 annulus components and the existing exact-transfer gates also pass. The tested feature implementation is ef62a45; this review branch applies only the two-file point-evaluation change onto current development. Four matched complete h=1/32 annulus workflows (case1/case2, serial/MPI16) also pass: velocity, pressure, topography and potential fields remain unchanged within 1.4e-14 relative difference; native potential coefficients agree with independent affine-P2 interpolation on the same physical-circle grid within 3.4e-16 of reference magnitude. The independent audit separately refines angular quadrature.