Repository navigation
Conversation
Region filtering previously selected boundary enum members from rank-local strata. A coarse extracted annulus lost Upper on some ranks, causing KeyError in natural Stokes boundary registration while peers entered collectives. Union label presence over the DM communicator and create empty labels where globally retained boundaries have no local points. Preserve candidate order and exclude globally absent labels. Validation: two focused regressions pass serial and on each of two MPI ranks, including actual region extraction. No equations, coordinates, partitioning or finite-element values change. Next validate the existing int32 Gadi installation gates and rerun only the four affected coarse Poisson models.
gthyagi
marked this pull request as ready for review
October 23, 2026 07:15
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracting a distributed region currently builds each rank’s boundary enum from locally surviving strata. A coarse annulus mantle extraction can omit
Upperon a rank with no upper-wall points. Registering the natural Stokes boundary condition then raisesKeyError: Upperwhile other ranks enter collective solver setup.This change selects surviving boundary names over the submesh communicator and creates empty local labels for globally retained boundaries. Candidate order is preserved, and labels absent everywhere remain excluded. It changes metadata, not mesh coordinates, partitioning or equations.
Validation: two focused regressions pass serial and on both MPI ranks, including actual region extraction and an intentionally empty local label. The fresh Gadi PETSc int32 build passed 34 serial checks and 4 checks on each of 16 MPI ranks. All four affected case1/case2 Poisson models at h=1/8 and h=1/16 completed successfully on 16 ranks after the fix; the original failures are retained. No spherical models or tests are run.