Skip to content

fix(crawler): await dispatcher stream aclose in arun_many #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Solaris-star wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −4
Open

fix(crawler): await dispatcher stream aclose in arun_many #2089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions crawl4ai/async_webcrawler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,13 +1107,19 @@ async def maybe_release_session():

if stream:
async def result_transformer():
# Hold an explicit reference so aclose() on the public generator
# always awaits dispatcher-owned task cleanup (#2083). Relying
# only on async-for teardown can release the proxy session while
# crawl tasks from the closed stream are still running.
stream_gen = dispatcher.run_urls_stream(
crawler=self, urls=urls, config=config
)
try:
async for task_result in dispatcher.run_urls_stream(
crawler=self, urls=urls, config=config
):
async for task_result in stream_gen:
yield transform_result(task_result)
finally:
# Auto-release session after streaming completes
await stream_gen.aclose()
# Auto-release session after dispatcher cleanup finishes
await maybe_release_session()

return result_transformer()
Expand Down