Fix NlpSentenceChunking destroying sentence order#1911
Closed
SamSi0322 wants to merge 1 commit intounclecode:mainfrom
Closed
Fix NlpSentenceChunking destroying sentence order#1911SamSi0322 wants to merge 1 commit intounclecode:mainfrom
SamSi0322 wants to merge 1 commit intounclecode:mainfrom
Conversation
list(set(sens)) is unordered — sentences were returned in arbitrary order instead of document order. Replaced with dict.fromkeys() which deduplicates while preserving insertion order. Closes unclecode#1909
Collaborator
|
Thanks for your contribution. While fixing this, I also found that NlpSentenceChunking.init() had a broken re-import (from crawl4ai.le.legacy.model_loader import ...) that shadows the working top-level import. So I've made a new PR, #1913 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NlpSentenceChunking.chunk()usedlist(set(sens))to deduplicate sentences, butset()is unordered in Python — this destroyed document sentence order, producing arbitrarily shuffled chunks.Fix: Replaced with
list(dict.fromkeys(sens))which deduplicates while preserving insertion order (Python 3.7+).Closes #1909