Fixed arun_many failing during deep crawling#1706
Open
vikas-gits-good wants to merge 7 commits intounclecode:developfrom
Open
Fixed arun_many failing during deep crawling#1706vikas-gits-good wants to merge 7 commits intounclecode:developfrom
vikas-gits-good wants to merge 7 commits intounclecode:developfrom
Conversation
Author
|
can you review it once? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arun_manynot working withDeepCrawlStrategy.dispatch_resultattribute ofCrawlResultwasn't being updated correctly.Fixes #1277
List of files changed and why
DeepCrawlDecoratorincrawl4ai.deep_crawling.base_strategywas changed as it was returning aList[CrawlResultContainer]toarun_manywhich is an incompatible datatype. The data was flattened as explained in the issue comment.arun_manyincrawl4ai.async_webcrawler.AsyncWebCrawlerwas changed as the datatype needed further modification.dispatch_resultattribute ofCrawlResultwas not being updated. Fixed that as well.How Has This Been Tested?
Use this file to check.
Checklist: