-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Querying: Restore ability to retrieve all children published in any culture (closes #20760) #20766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Querying: Restore ability to retrieve all children published in any culture (closes #20760) #20766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for using "*" (Constants.System.InvariantCulture) as a culture parameter to retrieve published content across all cultures, rather than being limited to a specific culture. This aligns with behavior from previous Umbraco versions.
Key changes:
- Updated
PublishedContentStatusFilteringServiceto bypass culture filtering when"*"is provided - Modified
PublishStatusServiceto treat"*"as "published in any culture" - Added comprehensive test coverage for the
"*"culture parameter across different content variance scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Umbraco.Core/Services/PublishStatus/PublishedContentStatusFilteringService.cs |
Renamed method and added logic to bypass culture filtering when "*" is requested |
src/Umbraco.Core/Services/PublishStatus/PublishStatusService.cs |
Added check to treat "*" as "published in any culture" |
tests/Umbraco.Tests.UnitTests/Umbraco.Core/Services/PublishStatus/PublishedContentStatusFilteringServiceTests.cs |
Added test cases for "*" culture parameter and corresponding assertions for variant and mixed variance scenarios |
...UnitTests/Umbraco.Core/Services/PublishStatus/PublishedContentStatusFilteringServiceTests.cs
Outdated
Show resolved
Hide resolved
|
Just a question, why doesn't this make the RTM? I mean isn't this breaking functionality for a lot of people? |
|
Once we are in the release candidate period @GianniDPC, we try to limit updates to clear regressions from the previous minor release, or fixes to new features introduced with the release. This is to lessen the risk of introducing issues after a considerable amount of internal and external testing is completed. This issue goes back likely all the way to Umbraco 14, so didn't fall into that category, and as such we targeted it for 17.1. There will be an RC of that version out 4 weeks after the release of 17.0 |
Ok. Thanks again for solving this issue! |

Prerequisites
Addresses #20760
Description
The linked issue notes that in 13 you could call
ChildrenForAllCulturesorChildren("*")to get all children published in any culture. The former method has been removed but the latter doesn't work the same as in 13 (it now returns no children as it looks for documents published in the specific culture of "*", which of course doesn't exist).This PR restores the 13 behaviour by allowing a request to
Children("*")to get all children published in any culture.Testing
Review unit test and verify manually with the following setup:
Request children with code like the following and verify results are as expected (all documents published in any culture are shown).