Skip to content

Conversation

@engijlr
Copy link
Contributor

@engijlr engijlr commented Oct 30, 2025

Summary

This PR updates multiple property editors to align with the UmbFormControlMixin pattern.

Changes:

Color Picker
-Extended UmbFormControlMixin in both outer and inner elements.
-Added support for mandatory and mandatory message, passed down as required and requiredMessage.
-Bound inner input in the outer.
-Added a validator for missing value in the inner.

Content Picker
-Added mandatory support.
-Prevents validation when readonly is true to avoid unnecessary submission blocking.

Date Picker
-Extended UmbFormControlMixin in the outer.
-Relies on native input validation.
-Bound inner input in the outer.

Document Picker
-Extended UmbFormControlMixin in the outer.
-Added mandatory and mandatory message support.
-Bound inner input in the outer.

Eye Dropper
-Extended UmbFormControlMixin in both outer and inner.
-Added mandatory and mandatory message support.
-Bound inner input in the outer.
-Added validator for missing value.

Multi URL Picker
-Extended UmbFormControlMixin in the inner.
-Added mandatory and mandatory message support.
-Added validator for missing value.

Result

All mentioned property editors now:

  • Use UmbFormControlMixin as a single source of truth for form control behavior.
  • Support mandatory validation in a consistent way.
  • Properly bind their inner input element for form state tracking.

Additional it fixes #17751

@iOvergaard iOvergaard changed the base branch from v17/dev to main October 30, 2025 10:52
@nielslyngsoe nielslyngsoe enabled auto-merge (squash) November 14, 2025 13:28
@nielslyngsoe nielslyngsoe merged commit 01b3003 into main Nov 14, 2025
26 of 28 checks passed
@nielslyngsoe nielslyngsoe deleted the v17/improvement/pickers-property-editors branch November 14, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split View Fails to Show Date/Time Field Updates for Shared Fields

3 participants