-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Property Editors: Added form control and mandatory support to editors in picker group(Color, Content, Date, Document, Eye dropper, Multi URL). #20684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the eye dropper.
src/Umbraco.Web.UI.Client/src/packages/core/components/input-color/input-color.element.ts
Outdated
Show resolved
Hide resolved
...co.Web.UI.Client/src/packages/core/components/input-eye-dropper/input-eye-dropper.element.ts
Outdated
Show resolved
Hide resolved
...co.Web.UI.Client/src/packages/core/components/input-eye-dropper/input-eye-dropper.element.ts
Show resolved
Hide resolved
...Client/src/packages/property-editors/color-picker/property-editor-ui-color-picker.element.ts
Show resolved
Hide resolved
nielslyngsoe
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates multiple property editors to align with the UmbFormControlMixin pattern.
Changes:
Color Picker
-Extended UmbFormControlMixin in both outer and inner elements.
-Added support for mandatory and mandatory message, passed down as required and requiredMessage.
-Bound inner input in the outer.
-Added a validator for missing value in the inner.
Content Picker
-Added mandatory support.
-Prevents validation when readonly is true to avoid unnecessary submission blocking.
Date Picker
-Extended UmbFormControlMixin in the outer.
-Relies on native input validation.
-Bound inner input in the outer.
Document Picker
-Extended UmbFormControlMixin in the outer.
-Added mandatory and mandatory message support.
-Bound inner input in the outer.
Eye Dropper
-Extended UmbFormControlMixin in both outer and inner.
-Added mandatory and mandatory message support.
-Bound inner input in the outer.
-Added validator for missing value.
Multi URL Picker
-Extended UmbFormControlMixin in the inner.
-Added mandatory and mandatory message support.
-Added validator for missing value.
Result
All mentioned property editors now:
Additional it fixes #17751