Conversation
|
oh also i'm not sure how this is implemented in prod, if any changes need to be made for the page to actually work IRL let me know lol. |
There was a problem hiding this comment.
This PR looks good ! I think we put the index.html/style.css into maybe like /src/ or even /src/public/ as / is already getting pretty messy. I think maybe in the future a re-theme that looks more umassy could be cool, but i won't let perfect be the enemy of good
index.html
Outdated
| </main> | ||
| <hr /> | ||
| <footer> | ||
| <a id="addsite" href="https://github.com/umacabal/umaring/pulls" |
There was a problem hiding this comment.
| <a id="addsite" href="https://github.com/umacabal/umaring/pulls" | |
| <a id="addsite" href="https://github.com/umacabal/umaring/" |
I think just bringing people to the readme makes more sense since it includes instructions as opposed to just dropping someone on the PR page
styles.css
Outdated
| font-size: 45px; | ||
| font-weight: 500; | ||
| letter-spacing: 0.05em; | ||
| text-shadow: 0px 0px 2px #d9d9d9; |
There was a problem hiding this comment.
I realllly don't like shadow like this, it just feels a little fuzzy
There was a problem hiding this comment.
Yeah that's fair. I'm honestly not a huge fan of the overall look either, but like you said we can look at making things more UMass later since I really have no ideas.
src/get.rs
Outdated
| } | ||
|
|
||
| pub async fn landing_page() -> Result<Response<String>, std::convert::Infallible> { | ||
| match read_to_string("index.html").await { |
There was a problem hiding this comment.
Sorry, I just realized, currently we only copy the binary to the container and not any assets or resources so I don't think this read_to_string would work in the docker container. It's why we use include_str!, if we move the files into their own directory like /public/ we could copy it into the container and then do a static serving with something like ServeDir
There was a problem hiding this comment.
Did not know about ServeDir! Made everything so much easier.
|
Sorry this took so long to get back to! Everything that was mentioned has been fixed. The Docker container works (on my machine) - should be good to go. |
haylinmoore
force-pushed
the
main
branch
3 times, most recently
from
3406607 to
9801520
Compare
2 participants
Adds a landing page for the ring as discussed here.
Contains a list of current members and a link to submit your own site to the repo.
A few notes: