Skip to content

Change set_filenames in single_run fixture to use file name instead of folder path - #4567

Open
clmould wants to merge 1 commit into
mainfrom
pytest-dir-tmp-path
Open

Change set_filenames in single_run fixture to use file name instead of folder path#4567
clmould wants to merge 1 commit into
mainfrom
pytest-dir-tmp-path

Conversation

@clmould

@clmould clmould commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Description

Previously this test was using the tmp_path in set_filenames, leading to files being created with the name of the test inside a folder of the same name:
image

This change means the files created during a run of pytest now have the name of the file preserved:
image

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould
clmould requested a review from a team as a code owner August 28, 2026 08:38
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.86%. Comparing base (85b3f55) to head (b57995e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4567   +/-   ##
=======================================
  Coverage   49.86%   49.86%           
=======================================
  Files         151      151           
  Lines       29867    29867           
=======================================
  Hits        14892    14892           
  Misses      14975    14975           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants