Support a local repository of regression test assets - #4560
Open
timothy-nunn wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4560 +/- ##
=======================================
Coverage 49.49% 49.49%
=======================================
Files 151 151
Lines 30076 30076
=======================================
Hits 14885 14885
Misses 15191 15191 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
clmould
requested changes
Aug 28, 2026
clmould
left a comment
clmould
left a comment
Collaborator
There was a problem hiding this comment.
v minor , but happy otherwise :)
| # - MY_IN.DAT -> MY_MFILE.DAT | ||
| # - myIN.DAT -> myMFILE.DAT | ||
| # This naming convention is consistent with PROCESS but is inconsistent with the | ||
| # remote repoistory for legacy reasons (i.e. scenario_name does not follow |
Collaborator
There was a problem hiding this comment.
Suggested change
| # remote repoistory for legacy reasons (i.e. scenario_name does not follow | |
| # remote repository for legacy reasons (i.e. scenario_name does not follow |
| """Tests each input file in the 'input_files' directory. | ||
|
|
||
| The test will locate and download a remote reference MFile that was | ||
| generated by running the input file on the 'main' branch. |
Collaborator
There was a problem hiding this comment.
Can you update this to include the --local-repository option plz
| :param reg_tolerance: user specified tolerance, percentage differences below which | ||
| are ignored. | ||
| :type reg_tolerance: float | ||
| :param opt_params_only: if True, user specificied that only optimisation parameters |
Collaborator
There was a problem hiding this comment.
Suggested change
| :param opt_params_only: if True, user specified that only optimisation parameters |
sorry i just saw that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.