-
Notifications
You must be signed in to change notification settings - Fork 18
🧲 Refactor croco 3 #4246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chris-ashe
wants to merge
50
commits into
main
Choose a base branch
from
refactor_croco_3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
🧲 Refactor croco 3 #4246
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
eafc889
Add CROCOAveragedTurnGeometry class and update CROCOSuperconductingTF…
chris-ashe 8da6224
Remove unused i_tf_sc_mat parameter from CICCSuperconductingTFCoil an…
chris-ashe 5808ce6
Refactor CICCSuperconductingTFCoil to simplify cable calculations by …
chris-ashe cfa6723
Update main_plot to handle different superconducting turn types and i…
chris-ashe 5dec6cb
Add output_croco_info method to CROCOSuperconductingTFCoil for detail…
chris-ashe d903cdc
Add plot_tf_croco_turn function for visualizing TF coil CICC turn str…
chris-ashe 20d5fd2
Remove unsupported integer turn geometry handling for CroCo conductor…
chris-ashe d6f4541
Refactor CROCOSuperconductingTFCoil to streamline conductor area calc…
chris-ashe 873c282
Post rebase summary file changes
chris-ashe eb05756
Add effective cable space area calculation in CROCOSuperconductingTFCoil
chris-ashe ec35521
Refactor CROCOSuperconductingTFCoil to update Croco cable diameter va…
chris-ashe 1bd0b11
Enhance CroCo cable geometry calculations by adding tape stack height…
chris-ashe 9ea5c98
Add CroCo cable geometry data class and summary box for plotting
chris-ashe 3029043
Add HTS tape geometry plotting function and update CroCo cable plot p…
chris-ashe bd6108f
Refactor CroCo strand calculations to use N_CROCO_STRANDS_TURN consta…
chris-ashe b8b04e3
Refactor CroCo cable geometry calculations to return CroCoCableGeomet…
chris-ashe d44630f
Refactor CROCOSuperconductingTFCoil to utilize calculate_croco_cable_…
chris-ashe 75bb5de
Refactor variable names for TF coil components
chris-ashe 757b94a
Update tests
chris-ashe 40e1c0f
Rename croco superconductor
chris-ashe 302bd89
Pass out function terms
chris-ashe 2329fb5
Add CroCoCableSpaceGeometry class and refactor cable space calculatio…
chris-ashe c109367
Add TFSuperconductorLimits dataclass and refactor superconductor prop…
chris-ashe 6e5c6cc
Refactor CroCo cable geometry calculations and remove deprecated croc…
chris-ashe 98a3045
Refactor jcrit_rebco function to return additional critical propertie…
chris-ashe e0bb1dc
Refactor CroCo copper bar area variable and update related calculatio…
chris-ashe 4f1adae
Refactor CroCo strand critical current variable and update related ca…
chris-ashe 5643cb4
Refactor CroCo copper area variables and update related calculations …
chris-ashe 53e511a
Rename `conductor_hastelloy_area` to `a_tf_turn_croco_hastelloy`
chris-ashe 382c106
Refactor superconductor classes to add type hints and clean up unused…
chris-ashe 6728569
Update tests
chris-ashe bcd9094
Refactor output methods in TFCoil classes to use output_general_tf_in…
chris-ashe 5dc8be7
Move `e_tf_magnetic_stored_total` variable from superconducting to n…
chris-ashe 9762188
Rename `oacdcp` to `j_tf_coil_full_area` across multiple files for cl…
chris-ashe cea94bb
Update TF coil variable descriptions for clarity and consistency
chris-ashe 2f82047
Refactor TFCoil output methods to use instance outfile and add genera…
chris-ashe e97c901
Post rebase changes
chris-ashe 54fe946
Enhance output methods for resistive and superconducting TF coils, ad…
chris-ashe d78b113
Enhance SuperconductingTFTurnType enum to include full names and impr…
chris-ashe 01bed8c
Refactor radial build output methods for resistive and superconductin…
chris-ashe d4f2824
Add detailed resistive loss parameters output for ResistiveTFCoil class
chris-ashe 8aca4cb
Enhance output structure and clarity for SuperconductingTFCoil class
chris-ashe f3b717a
Refactor output methods for CroCo superconducting TF coil, enhancing …
chris-ashe 2e8843c
Add dx_tf_hts_tape_total to CroCoCableGeometry and update CROCOSuperc…
chris-ashe ded5567
Fix calculation of internal diameter in CroCo cable geometry by adjus…
chris-ashe 6f28c04
Post rebase fixes
chris-ashe c27d93e
Update process/core/input.py
chris-ashe 02b98dc
Update obsoelete vars
chris-ashe 9a17bf7
Requested changes
chris-ashe c85050a
Refactor stress calculation in SuperconductingTFCoil class and stream…
chris-ashe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.