Skip to content

Clean up logging in controller and wrap errors#132

Open
yushan8 wants to merge 11 commits into
mainfrom
update-logging
Open

Clean up logging in controller and wrap errors#132
yushan8 wants to merge 11 commits into
mainfrom
update-logging

Conversation

@yushan8

@yushan8 yushan8 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor
  • Replaced common.WithReason with fmt.Errorf for error wrapping in getchangedtargets.go and getGraph.
  • Promoted silent failures to hard errors — cache read failures, corrupt blobs, and cachedReader.Close() errors now return instead of logging and falling through.
  • Surfaced ws.Release() errors in native_orchestrator.go via multierr.Append instead of swallowing them.
  • Added logger.Error at each error return in top-level controller (GetTargetGraph, GetChangedTargets) with specific failure messages.
  • Removed non-actionable logs — cache miss debug logs, bypass_cache logs, context cancelled logs.
  • Removed unused logger param from compareTargetGraphs.
  • Updated tests to match new error wrapping and removed ClassifiedError assertions where common.WithReason was replaced.

@yushan8 yushan8 requested review from a team as code owners June 30, 2026 22:36
Comment thread controller/getchangedtargets.go
Comment thread controller/getchangedtargets.go Outdated
Comment thread orchestrator/BUILD.bazel Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants