Update card.tsx - #5415
Open
MaddipatlaChetan24 wants to merge 1 commit into
Open
Conversation
MaddipatlaChetan24
requested review from
DianaSuvorova,
dyesin,
hualf1995 and
lijim
as code owners
September 7, 2026 13:42
Contributor
Author
|
can you please check this !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2
Description
Hoists the
levelsarray (['', 'h1', 'h2', 'h3', 'h4', 'h5', 'h6']) out ofthe
SemanticTitlecomponent inCardinto a module-level constant(
HEADING_LEVELS). Previously this array literal was re-allocated on everyrender of
SemanticTitle, which runs for everyCardwith atitleandre-runs on every re-render. The array's contents never change, so it only
needs to be allocated once at module load. No change to rendered output or
component behavior.
Scope
Patch: Bug Fix