Update Button component, ubook stories and docs #5377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hualf1995
force-pushed
the
linfeng-button
branch
from
59d32bd to
2134006
Compare
Deploying baseweb with
|
| Latest commit: |
2134006
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d9fecacd.baseweb.pages.dev |
| Branch Preview URL: | https://linfeng-button.baseweb.pages.dev |
hualf1995
commented
Jan 5, 2026
|
|
||
| <Yard placeholderHeight={52} {...buttonYardConfig} /> | ||
|
|
||
| <Notification |
Collaborator
Author
There was a problem hiding this comment.
Added a deprecation note on doc
hualf1995
commented
Jan 5, 2026
| tagLimeBorderSecondaryUnselected: primitiveDarkColors.lime500Dark, | ||
| tagLimeBorderSecondarySelected: primitiveDarkColors.lime800Dark, | ||
| }; | ||
| const hoveredAndPressedColors: HoveredAndPressedSemanticColors = { |
Collaborator
Author
There was a problem hiding this comment.
Copied from base-specs
DianaSuvorova
approved these changes
Jan 5, 2026
| const [css] = useStyletron(); | ||
| const [isSelected, setIsSelected] = React.useState(false); | ||
|
|
||
| console.log('isSelected', isSelected); |
Collaborator
Author
There was a problem hiding this comment.
good catch! I'll remove it in my next PR for button group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scope
Minor: New Feature
Will bump the version after we sync other components.