Merged
Conversation
After getting access to a second dataset which is a lot more cache-friendly than the original (while also being a real-world sample), I think it makes sense to cache the "fast" resolvers as well: going back to the original commit (b45380d) an S3Fifo(5000) was estimated to take about 3.5MB when full (0.5MB of cache metadata, and 3MB of actual cached data), so an S3Fifo(2000) would be about 1.5MB or thereabouts which is not nothing... but is pretty much nothing compared to the RSS impact of the advanced parsers. Fixes ua-parser#302
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After getting access to a second dataset which is a lot more cache-friendly than the original (while also being a real-world sample), I think it makes sense to cache the "fast" resolvers as well: going back to the original
commit (b45380d) an S3Fifo(5000) was estimated to take about 3.5MB when full (0.5MB of cache metadata, and 3MB of actual cached data), so an S3Fifo(2000) would be about 1.5MB or thereabouts which is not nothing... but is pretty much nothing compared to the RSS impact of the advanced parsers.
Fixes #302