Optimize NativeString: add UTF-8 conversion fast path - #1302
Open
ValoChet wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaScript strings are stored either as Latin-1 or UTF-16, and uWS always convert them to UTF-8.
For small strings, we can avoid the extra
Utf8Length()pass by using a safe worst-case allocation size:2 * sizein worst case3 * sizein worst caseIf this worst-case size fits in the pool buffer, we can call
WriteUtf8()directly.It writes the UTF-8 data into the pool and returns the exact number of bytes written.
The pool offset is then advanced by the actual number of bytes used.
This should cover most strings thanks to the generous 128 KB pool.
I the string is too large, it fallback calculating the exact size.
Test case: 10 x
writeHeader(32 bytes, 32 bytes)