Avoid unnecessary allocation in Uncancelable trait.#4600
Open
nmichael44 wants to merge 1 commit intotypelevel:series/3.xfrom
Open
Avoid unnecessary allocation in Uncancelable trait.#4600nmichael44 wants to merge 1 commit intotypelevel:series/3.xfrom
nmichael44 wants to merge 1 commit intotypelevel:series/3.xfrom
Conversation
…ed to MonadCancel object).
Contributor
Author
|
This fails one of the tests with: This happens since there are no longer any fields in the trait and so the Scala compiler eliminates the Please advice what the right thing to do is in this case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary allocation in Uncancelable trait for idPoll. We can just allocate it once in object
MonadCanceland apply the usual Id Monad trick (as in for exampleResource.liftK).