Open
Conversation
Merged
Member
|
This looks really nice! I think we're going to need a Scala 3 version though before it can be merged, but otherwise I'm in favor! |
Collaborator
Author
I've started doing it and encountered the Scala3-macro brickwall that I'm slowly digging through. I was hoping it'd take me a lot less time than it has. I think I'm gonna have to ask for help. |
Member
Yeah this is a particularly rough one, since we have to implement the whole transformation ourselves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
parallelversion of theasyncmethod, which translates the block intoF.delay+parMapNcalls.The macro attempts to protect against ill-use by preventing any definition in the
parallelregion to be used in its containedawaitcalls, as it would prevent the rewrite toparMapNfrom compiling.