Update Finagle to 22.12.0 #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #521 +/- ##
=======================================
Coverage 90.60% 90.60%
=======================================
Files 18 18
Lines 298 298
Branches 2 2
=======================================
Hits 270 270
Misses 28 28 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
I'm kind of surprised there were no breaking changes in this release. Can we double-check that the MiMa "extra projects" are being checked correctly? If so, this lgtm. |
Member
Author
|
@bpholt Indeed, the MiMa isnt set up correctly and doest run on the rootFinagle project. Will check :) |
Member
Author
|
Member
Author
|
@bpholt Im a bit confused on why we run a MiMa on Finagle itself though? Just an extra manual check when bumping versions? |
Member
My bad, either I forgot when I set it up, or for some reason decided that it would be invoked manually during upgrade PRs like this (presumably because it would be too annoying to add filters). In any case we can change this if you want. |
Member
Our team has run into a lot of bincompat issues with Finagle/Twitter Utils over the years, so it's helpful information to have when deciding when to pull in updates. (If there are bincompat issues then you need to update everything using Finagle, including support libraries like this one, etc) Since it looks like this does pull in binary-breaking changes, we need to make sure the artifact is published with the right version scheme metadata so that e.g. Scala Steward sees this as a major version bump. |
Member
Author
|
@bpholt Two things then :)
|
Member
|
I'd lean towards adding it to the build. If it turns out to be too annoying, we can adjust it later. I think we need |
Member
|
Lines 31 to 32 in 78cd0ec |
Member
|
@armanbilge good catch. Ok, I think we're probably in good shape with that part of it! |
bpholt
reviewed
Mar 2, 2023
project/FinaglePlugin.scala
Outdated
| * versions it was checked against. | ||
| */ | ||
| val versions = Seq("22.7.0") | ||
| val versions = Seq("22.12.0", "22.7.0") |
Member
There was a problem hiding this comment.
Just to be explicit: I think we should remove "22.7.0" here, since we know 22.12.0 is not binary compatible with 22.7.0. Once that's done, rootFinagle/mimaReportBinaryIssues should run cleanly, and we can add it to the build.
bpholt
approved these changes
Mar 6, 2023
Member
|
Looks good! Once this is merged, we'll release |
Member
Author
|
@bpholt Normally yes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/twitter/finagle/releases