Migrate navbar examples/tests from collapse to drawer and remove deprecated .navbar-collapse#42745
Open
julien-deramond wants to merge 1 commit into
Open
Migrate navbar examples/tests from collapse to drawer and remove deprecated .navbar-collapse#42745julien-deramond wants to merge 1 commit into
.navbar-collapse#42745julien-deramond wants to merge 1 commit into
Conversation
…ecated `.navbar-collapse` Spotted in #42487
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted in #42487
Description
This PR updates all remaining navbar example and visual test markup to match the v6 navbar behavior.
The old collapse-based pattern (
data-bs-toggle="collapse"with.navbar-collapse) is replaced with drawer-based toggles and drawer containers, and the leftover deprecated.navbar-collapseusage is removed from the custom drawer example.This migration was needed because responsive navbar collapsing in v6 is implemented with Drawer, not Collapse, so these examples now reflect the current API and avoid deprecated classes.
Live previews