V2 #258
Open
V2 #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pager07
requested changes
Oct 20, 2025
app/api/postcodes.py
Outdated
|
|
||
| def get_postcode_service() -> PostcodeService: | ||
| """Dependency to get the postcode service from app state.""" | ||
| from app.main import postcode_service |
There was a problem hiding this comment.
Starting the server and making the request give this error.
It seems that PostcodeService is None, and not initialized
There was a problem hiding this comment.
haven't looked into detailed why this is happening but is seem that just changing the line to , fixes the issues
from main import postcode_service
|
Testing with correct / incorrect postcodes Testing with empty inputs Testing with incorrect types Testing with incorrect auth |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.