[pull] master from ruby:master#988
Merged
pull[bot] merged 5 commits intoturkdevops:masterfrom May 6, 2026
Merged
Conversation
This is how caches used to work prior to 913979b, however since inline cache need to be set atomically, they are limited to 64bits, which wasn't enough to store an `attr_index_t` and two `shape_id_t`. But now that we only cache the shape's offset, which is only 19B, we can store both the source and destination offsets along with the field index. Thanks to this, the cache validation is now much simpler, we only have to do an exact match on the source offset, whereas before if it wasn't an exact match, we had to try to match the parent, then check the field name. We however still have to validate the shape capacity, as the fast path doesn't handle resizes, but that could be handled in a followup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )