-
-
Notifications
You must be signed in to change notification settings - Fork 7
feat(types): add lexicon type generation #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for tsky canceled.
|
|
Just tried your PR and those types look really handy already. One thing I noticed is that it currently is based on |
Co-authored-by: Anbraten <6918444+anbraten@users.noreply.github.com>
bdbch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just two comments we could clarify. Cool idea!
Co-authored-by: Anbraten <6918444+anbraten@users.noreply.github.com>
…niks/tsky into feat/lexicon-type-generation
|
Closing this PR as its functionality has been superseded by #28 which was just merged. |
This PR adds a script to automatically:
@atproto/lex-cliNot ready for merge yet, but sharing for early feedback. Current status:
@atcute/lex-cli)Next steps:
@atcute/lex-cli)related to #30