Skip to content

Conversation

@bdbch
Copy link
Member

@bdbch bdbch commented Nov 30, 2024

No description provided.

@netlify
Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for tsky ready!

Name Link
🔨 Latest commit 9e42fc5
🔍 Latest deploy log https://app.netlify.com/sites/tsky/deploys/674eb6461024b50008a2f975
😎 Deploy Preview https://deploy-preview-17--tsky.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdbch bdbch changed the title maintainence: add biome vscode settings maintainence: add biome vscode settings & use biome instead of eslint Nov 30, 2024
@bdbch
Copy link
Member Author

bdbch commented Nov 30, 2024

I tried to use the eslint-config-biome but it didn't work as expected. I think only using one formatting/linting library should be fine and since biome allows us to do both (except markdown parsing & linting/formatting) I'd suggest we use biome by default then.

@bdbch bdbch changed the title maintainence: add biome vscode settings & use biome instead of eslint chore: add biome vscode settings & use biome instead of eslint Nov 30, 2024
@bdbch bdbch changed the title chore: add biome vscode settings & use biome instead of eslint feat: add biome vscode settings & use biome instead of eslint Nov 30, 2024
package.json Outdated
},
"nano-staged": {
"*.{js,ts,cjs,mjs}": ["biome check --write --"]
"*.{js,ts,cjs,mjs,json}": ["biome check --write --"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it support for markdown as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

biomejs/biome#3718

I think they're still working on that.


- name: 📝 Check format
run: pnpm format:check
run: pnpm format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the normal format throw errors if something is not formatted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is the equivalent to eslint without --fix

@bdbch bdbch closed this Dec 3, 2024
@bdbch bdbch force-pushed the bdbch/biome-vscode-setup branch from bd3b7dd to 9e42fc5 Compare December 3, 2024 07:41
@bdbch bdbch deleted the bdbch/biome-vscode-setup branch December 3, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants