Add 1 d chunking #119
Open
Add 1 d chunking #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromekelleher
force-pushed
the
add-1D-chunking
branch
from
9457139 to
df0c7fa
Compare
jeromekelleher
force-pushed
the
add-1D-chunking
branch
from
df0c7fa to
e95adec
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
- Coverage 97.32% 96.88% -0.45%
==========================================
Files 6 7 +1
Lines 337 385 +48
Branches 56 62 +6
==========================================
+ Hits 328 373 +45
- Misses 7 8 +1
- Partials 2 4 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jeromekelleher
force-pushed
the
add-1D-chunking
branch
2 times, most recently
from
fe22945 to
36aa743
Compare
jeromekelleher
force-pushed
the
add-1D-chunking
branch
2 times, most recently
from
5b67175 to
041ed42
Compare
Also switch to 32MiB chunks Closes tskit-dev#69 Closes tskit-dev#118
jeromekelleher
force-pushed
the
add-1D-chunking
branch
from
041ed42 to
290a545
Compare
Member
Author
|
I think this is ready to go in once we've validated that it actually does fix compression on very large files. I don't have an example lying around handy (raw sc2ts output triggers this, which is what's motivated me to do it!) I checked in terms of compression performance on the final sc2ts output, and the files are very slightly larger. It's not worth worrying about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for #118