feat: add support --download flag to downloading and localizing 3D models from JLCPCB#2471
feat: add support --download flag to downloading and localizing 3D models from JLCPCB#2471techmannih wants to merge 3 commits intotscircuit:mainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
seveibar
left a comment
There was a problem hiding this comment.
always avoid using regex unless it greatly simplifies a solution, regex should never make a solution more complex (it makes it more complex here)
The easyeda converter converts circuit json into tsx internally, can't you use that to simplify this implementation and avoid regex.
Can you also make sure to properly handle the step model url, which was in the original feature request Ray made (this wouldn't have helped him because you didn't handle step model urls)
Why do you handle multiple remote urls in this way? Simplify your code, use .find instead of filter to find the cad component.
This PR adds the ability to download and localize 3D models (OBJ files) when importing components from JLCPCB using the
tsci importcommand.Summary of Changes
--downloadflag to thetsci importcommand..objfiles directly from JLCPCB's CDN.content-dispositionheader to ensure the downloaded file uses the correct original filename from JLCPCB.