Repository navigation
Add Persian braille tables and language settings - #466
Open
mmfarahmand wants to merge 1 commit into
Open
mmfarahmand wants to merge 1 commit into
mmfarahmand wants to merge 1 commit into
Conversation
Download Persian Grade 1 braille (fa-ir-g1.utb) and Persian 8-dot computer braille (fa-ir-comp8.ctb) tables from the LibLouis repository. Register PERSIAN and PERSIAN_COMP8 in LibLouis translator factory and BrailleLanguages.Code enum, and add localized string resources for English and Persian (values-fa). Suppress MissingTranslation in lint.xml for the new resources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Persian braille tables and language settings
Description
Persian braille tables were previously missing from Backtalk, leaving Persian-speaking braille keyboard and braille display users without native braille translation tables.
This pull request adds Persian braille support using the official upstream LibLouis tables:
fa-ir-g1.utb): Standard 6-dot uncontracted literary braille.fa-ir-comp8.ctb): 8-dot computer braille for direct symbol representation.Changes
Tables (
:brailletranslate):fa-ir-g1.utbandfa-ir-comp8.ctbdirectly from LibLouis intobraille/translate/src/phone/tables/.spaces.uti,braille-patterns.cti, anddigits6Dots.uti) already exist in the tables directory.Translator Factory (
:brailletranslate):PERSIANandPERSIAN_COMP8inLibLouis.java's switch expression to instantiateLibLouisTranslatorwith the respective table files.Language Model & Enum (
:braillecommon):LOCALE_FA = Locale.forLanguageTag("fa")inBrailleLanguages.java.Code.PERSIANandCode.PERSIAN_COMP8enum values.PERSIAN(Grade 1) is selected as default when the device locale is Persian (fa/fa_IR).Localization (
:braillecommon):code_user_facing_name_persian("Persian") andcode_user_facing_name_persian_comp8("Persian 8-dot Computer Braille") with char limit comments tovalues/strings.xml.values-fa/strings.xml, matching the phrasing used across existing languages.Lint (
lint.xml):<ignore regexp="code_user_facing_name_persian.*" />underMissingTranslationso that other locales can be translated incrementally without failing lint checks.lint-baseline.xml.Testing
spaces.uti,braille-patterns.cti,digits6Dots.uti).