Repository navigation
Compare the remaining MCP methods with the Method enum - #441
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #438.
#437 added
App\Enums\Mcp\Methodand used it inLoadMcpWorkspace. This moves the three MCP files that still compared the JSON-RPC method as a string:ChallengeChatGptToolCalls:'tools/call'→Method::ToolsCall->valueChatGptMcpClient::DISCOVERY_METHODS: built from the enum cases' valuesTryPostServer::boot():addMethod(Method::ToolsList->value, ...)The request body is still compared as a raw value (
containsStrict), never throughtryFrom(), so a non-scalarmethodkeeps getting laravel/mcp's JSON-RPC error instead of a TypeError (.ai/rules/mcp.md). The rule's note pointing at this issue is removed.Tests
php artisan test --compact tests/Feature/Mcp: 553 passed,ChatGptSignInTestunchanged