Skip to content

Wait out a concurrent token refresh instead of failing the caller #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gynsus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Wait out a concurrent token refresh instead of failing the caller #313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion app/Services/Social/ConnectionVerifier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
use App\Services\Social\Discord\DiscordClient;
use App\Services\Social\Meta\GraphError;
use App\Services\Social\Telegram\TelegramApi;
use Illuminate\Contracts\Cache\LockTimeoutException;
use Illuminate\Http\Client\PendingRequest;
use Illuminate\Support\Facades\Cache;
use Illuminate\Support\Facades\Http;
Expand Down Expand Up @@ -204,7 +205,18 @@ public function refreshToken(SocialAccount $account): bool
$lock = Cache::lock("token_refresh:{$account->id}", self::REFRESH_LOCK_SECONDS);

if (! $lock->get()) {
// Another process is already refreshing this token.
// Another process is already refreshing this token. Wait for it
// to finish before re-reading the row: re-reading immediately
// usually finds the not-yet-persisted old token (both jobs fire
// on the same cron tick) and needlessly fails the caller with a
// transient error even though a fresh token lands moments later.
try {
$lock->block(15);
$lock->release();
} catch (LockTimeoutException) {
// Fall through — the row is re-read either way.
}

$account->refresh();

if ($account->is_token_expired) {
Expand Down