feat(ecmascript): get PlainTime.prototype.minute#955
Merged
aapoalas merged 4 commits intotrynova:mainfrom Feb 24, 2026
Merged
Conversation
aapoalas
requested changes
Feb 21, 2026
Member
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
Needs rebase, and also most likely will need to update test262 results.
See CONTRIBUTING.md for how to run the test262 update (requires checking out the test262 git submodule and running the test262 cargo bin command with the -u update flag).
Foo Fix warnings
aapoalas
requested changes
Feb 23, 2026
Member
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
Still needs cargo fmt and the test results to be updated. This should do the trick, I believe:
git submodule init && git submodule update && cargo build --profile dev-fast && cargo run --bin test262 --profile dev-fast -- -u
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.