Skip to content

[comp] Production Deploy#2941

Merged
Marfuen merged 2 commits into
releasefrom
main
May 28, 2026
Merged

[comp] Production Deploy#2941
Marfuen merged 2 commits into
releasefrom
main

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 28, 2026

This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.


Summary by cubic

Standardized finding status permissions. Members with finding:update can set ready_for_review; needs_revision and closed require finding:create or platform admin.

  • Bug Fixes

    • Removed auditor-only restriction on ready_for_review in API and UI.
    • Status options and content editing now respect permissions (finding:update, finding:create) instead of raw role names.
  • Refactors

    • Use RolesService to resolve permissions; add RolesModule to FindingsModule.
    • Change FindingsService.update to accept canCreateFindings; update admin controller call site.
    • Add unit tests for status transition rules.

Written for commit 559c67b. Summary will update on new commits.

Review in cubic

@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app (staging) Ready Ready Preview, Comment May 28, 2026 2:53pm
comp-framework-editor (staging) Ready Ready Preview, Comment May 28, 2026 2:53pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal (staging) Skipped Skipped May 28, 2026 2:53pm

Request Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@Marfuen Marfuen merged commit da56446 into release May 28, 2026
14 checks passed
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.64.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants