Skip to content

[comp] Production Deploy#2460

Open
github-actions[bot] wants to merge 1 commit intoreleasefrom
main
Open

[comp] Production Deploy#2460
github-actions[bot] wants to merge 1 commit intoreleasefrom
main

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Apr 3, 2026

This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.

…m Yes to No and not the other way around

CS-208: [Bug] - Statement of Applicability only allows you to change answers from Yes to No and not the other way around
@cursor
Copy link
Copy Markdown

cursor bot commented Apr 3, 2026

PR Summary

Medium Risk
Moderate UI/state changes in SOA answering that alter how applicability/justification are displayed and how manual saves override autofill results, which could impact what users see immediately after edits.

Overview
Updates the SOA applicability cell UX by replacing the YES/NO badge with a new swatch-based ApplicableReadOnlyDisplay and matching select items (ApplicableSwatchRow).

Changes the save/update flow so EditableSOAFields reports a structured { isApplicable, justification } payload; table state now stores savedIsApplicable (SOATableAnswerData) to let manual edits immediately override autofill/processed results on both desktop and mobile without a full reload.

Written by Cursor Bugbot for commit d164c77. This will update automatically on new commits. Configure here.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app (staging) Ready Ready Preview, Comment Apr 3, 2026 8:08pm
comp-framework-editor Ready Ready Preview, Comment Apr 3, 2026 8:08pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal (staging) Skipped Skipped Apr 3, 2026 8:08pm

Request Review

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.


const handleEditClick = () => {
setIsEditing(true);
if (isApplicable === false) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit click no longer opens justification dialog for "No" answers

High Severity

handleEditClick no longer opens the justification dialog when isApplicable is already false. Since Radix UI's Select only fires onValueChange when the value actually changes, re-selecting "no" while it's already "no" won't trigger handleSelectChange. This means users can't access the justification dialog to edit justification text for existing "No" answers. The only workaround is switching to "Yes" first, which triggers an immediate destructive save via executeSave(true, null), wiping the previous justification.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants