Skip to content

CS-208: [Bug] - Statement of Applicability only allows you to change answers from Yes to No and not the other way around#2457

Merged
Marfuen merged 6 commits intomainfrom
chas/statement-of-applicability
Apr 3, 2026
Merged

CS-208: [Bug] - Statement of Applicability only allows you to change answers from Yes to No and not the other way around#2457
Marfuen merged 6 commits intomainfrom
chas/statement-of-applicability

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Apr 3, 2026

This is an automated pull request to merge chas/statement-of-applicability into dev.
It was created by the [Auto Pull Request] action.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Apr 3, 2026 7:25pm
comp-framework-editor Ready Ready Preview, Comment Apr 3, 2026 7:25pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal Skipped Skipped Apr 3, 2026 7:25pm

Request Review

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 3, 2026

PR Summary

Medium Risk
Changes SOA answer editing and optimistic table state by carrying both isApplicable and justification through the update path, which could affect how saved vs autofilled values display until SWR revalidation.

Overview
Fixes SOA applicability editing so answers can be changed both from Yes→No and No→Yes, and ensures saves immediately reflect in the table without relying on a full document reload.

This introduces a typed SOAFieldSavePayload and extends row answer state with savedIsApplicable, updating SOAFrameworkTable/SOATable/row components to use the payload and prefer the manually-saved applicability over autofill results. UI polish replaces the YES/NO badge with a consistent swatch+label display (ApplicableSwatchRow) in both read-only cells and the select menu.

Written by Cursor Bugbot for commit 1fe0728. This will update automatically on new commits. Configure here.

@chasprowebdev chasprowebdev changed the title [dev] [chasprowebdev] chas/statement-of-applicability CS-208: [Bug] - Statement of Applicability only allows you to change answers from Yes to No and not the other way around Apr 3, 2026
@linear
Copy link
Copy Markdown

linear bot commented Apr 3, 2026

@chasprowebdev
Copy link
Copy Markdown
Contributor

Recording:

applicability.mov

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@Marfuen Marfuen merged commit d164c77 into main Apr 3, 2026
11 checks passed
@Marfuen Marfuen deleted the chas/statement-of-applicability branch April 3, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants