tests: Prepare upstream Azure tests#210
tests: Prepare upstream Azure tests#210Jakob-Naucke wants to merge 7 commits intotrusted-execution-clusters:mainfrom
Conversation
|
#201 |
|
flakes RUN cargo build -p register-server $(if [ "release" = release ]; then echo --release; fi) /retest |
for installation of yq & parallel builds Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
for autoupdates Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
allows for not installing Cargo & downloading a number of packages for CI. Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
|
ping @alicefr |
| TRUSTEE_SERVICE => Ok((TRUSTEE_APP_LABEL, TRUSTEE_PORT, 31000)), | ||
| REGISTER_SERVER_SERVICE => Ok((REGISTER_SERVER_APP_LABEL, REGISTER_SERVER_PORT, 31001)), |
There was a problem hiding this comment.
nit: can we define these port as constants, in this way we know what they represent
| pub const KIND_TRUSTEE_PORT: i32 = 31000; | ||
| pub const KIND_REGISTER_SERVER_PORT: i32 = 31001; | ||
| pub const KIND_ATTESTATION_KEY_REGISTER_PORT: i32 = 31002; |
There was a problem hiding this comment.
Is it the right place here for those constant? They are more related to the test infrastructure
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alicefr, Jakob-Naucke The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
- Introduce kind_public type which exposes services - Track app labels in lib - some typos & reference instead of clone Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
so that tests on Kind with port forwarding can go without conflicts Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
|
New changes are detected. LGTM label has been removed. |
|
@Jakob-Naucke: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
See openshift/release#75842 for how I plan to use it