fix: let MCP OAuth popup show result before closing - #842
Merged
Merged
Conversation
The opener was closing the popup as soon as the callback broadcast, so the success screen never stayed visible. Close only the channel on result and leave self-close to PostMcpOauthScreen. Co-authored-by: Cursor <cursoragent@cursor.com>
govindavashishtha
requested review from
kumarsks619,
qaifi-tf,
sajal-truefoundry,
sayan-truefoundry and
vinit-truefoundry
as code owners
September 22, 2026 10:06
🦋 Changeset detectedLatest commit: a2b316c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vinit-truefoundry
approved these changes
Sep 22, 2026
govindavashishtha
enabled auto-merge (squash)
September 22, 2026 10:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
popup.close()as soon as the callback broadcasts success/failurePostMcpOauthScreencan show its result UI and close itself after the existing delay@truefoundry/trueforge-uiTest plan
pnpm --filter @truefoundry/trueforge-ui exec vitest run test/hooks/useMcpAuth.test.ts test/containers/McpOauthContainer/PostMcpOauthScreen.test.tsxMade with Cursor