docs: note that unannotated MCP tools skip approval - #832
Open
bhaveshpatel640 wants to merge 4 commits into
Open
bhaveshpatel640 wants to merge 4 commits into
bhaveshpatel640 wants to merge 4 commits into
Conversation
bhaveshpatel640
requested review from
chiragjn,
debajyoti-truefoundry,
heerambavi1998,
sr07asthana and
thesujai
as code owners
September 21, 2026 14:46
|
bhaveshpatel640
enabled auto-merge (squash)
September 21, 2026 14:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs: note that unannotated MCP tools skip approval
Note
Low Risk
Documentation-only changes to agent tool-approval defaults and MCP annotation behavior; no runtime code in this diff.
Overview
Updates Create an Agent docs so tool approval behavior matches the product:
require_approval_for_toolsdefaults to["@destructive"], not@writeand@destructive.Adds a Note explaining that
@write/@destructiveapply only to MCP tools the server annotates — unannotated orreadOnlyHint: truetools are not paused by default (even if they mutate state), with guidance to use literal tool names or@allwhen you need approval anyway. The UI checklist andmcp_serversAPI table are updated accordingly, plus clearer rules for how annotation selectors resolve.Reviewed by Cursor Bugbot for commit b678c7c. Bugbot is set up for automated code reviews on this repo. Configure here.