fix(runtime): error when tool_calls finish has no tools - #824
Open
YIKUAIBANZI wants to merge 1 commit into
Open
YIKUAIBANZI wants to merge 1 commit into
YIKUAIBANZI wants to merge 1 commit into
Conversation
Providers can emit finish_reason=tool_calls without a parsed tool-call payload. Treat that as a terminal error, matching the length path, so the turn does not silently complete.
YIKUAIBANZI
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
heerambavi1998,
sr07asthana and
thesujai
as code owners
September 21, 2026 08:37
🦋 Changeset detectedLatest commit: 455e615 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an LLM response has
finish_reason=tool_callsbut the assembled assistant message has notool_calls, the runtime currently treats the turn as a successfuldone. The model asked to call a tool, nothing is executed, and no error is emitted.This change treats that case the same way as
finish_reason=length: emit an error event and exit. For a sub-agent, the stored completion iserrorrather thandone, so the parent does not treat the child as successful.Fixes #447
Why
Observed on long multi-phase missions: a turn can end immediately after a
tool.responsewhile the lastmodel.messagestill hasfinish_reason=tool_calls. The existinglengthpath already refuses to finish asdone; an empty tool-call payload is the same class of incomplete model output.Tests
pnpm --filter @truefoundry/trueforge-core test -- tests/core/runtime/toolCallsFinishWithoutCalls.test.tsAGENT_DONEstatus iserrorerror, notdoneChecklist
@truefoundry/trueforge-core(patch)