fix(core): report missing tool calls as errors - #822
Open
rahulduvedi wants to merge 1 commit into
Open
rahulduvedi wants to merge 1 commit into
rahulduvedi wants to merge 1 commit into
Conversation
rahulduvedi
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
heerambavi1998,
sr07asthana and
thesujai
as code owners
September 21, 2026 08:17
🦋 Changeset detectedLatest commit: a1ed1f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a case where the model returns
finish_reason: tool_callswithout an actual tool call. Instead of silently marking the agent as done, it now surfaces an error for both root agents and sub-agents.I also added a regression test for this behavior.
Tested with
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:check.Addresses #447.